I'm glad you got it to work. Without more understanding of how the
macros and documents were stored and used, I can't say exactly why
making the document a .dot file fixed your problem.
And in fact, it's best practice to put macros into .dot files. Many
people regarded it as a step backward when Office 97 enabled macros
in documents.
But I stand by my belief (based on limited testing) that if you
upload a document containing a macro into SharePoint, nothing in
SharePoint itself removes or disables that macro if you or another
user downloads the file. (Of course, it's possible an anti-virus
product installed into SharePoint or the client desktop would do
that, apart from security settings in Office.)